From 44642776db48cdbf2853690d36ad4de39fc8e4e5 Mon Sep 17 00:00:00 2001 From: Ben Hutchings Date: Fri, 2 Dec 2016 23:06:18 +0000 Subject: [PATCH] module: Disable matching missing version CRC This partly reverts commit cd3caefb4663e3811d37cc2afad3cce642d60061. We want to fail closed if a symbol version CRC is missing, as the alternative may allow subverting module signing. Gbp-Pq: Topic bugfix/all Gbp-Pq: Name module-disable-matching-missing-version-crc.patch --- kernel/module.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/module.c b/kernel/module.c index 3f1de34c6d1..83c785ef67b 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -1316,9 +1316,8 @@ static int check_version(Elf_Shdr *sechdrs, goto bad_version; } - /* Broken toolchain. Warn once, then let it go.. */ - pr_warn_once("%s: no symbol version for %s\n", mod->name, symname); - return 1; + pr_warn("%s: no symbol version for %s\n", mod->name, symname); + return 0; bad_version: pr_warn("%s: disagrees about version of symbol %s\n", -- 2.30.2